Prune createVisibleSelectionDeprecated from FrameSelection

third_party/WebKit/Source/core/editing/DOMSelection.cpp

 /*
  * Copyright (C) 2007, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 215 matching lines @@
     return;
 
   const VisibleSelection& selection = frame()->selection().selection();
 
   if (selection.isNone()) {
     exceptionState.throwDOMException(InvalidStateError,
                                      "there is no selection.");
     return;
   }
 
+  // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
+  // needs to be audited.  See http://crbug.com/590369 for more details.
+  // In the long term, we should change FrameSelection::setSelection to take a
+  // parameter that does not require clean layout, so that modifying selection
+  // no longer performs synchronous layout by itself.
+  frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();
+
   frame()->selection().moveTo(selection.end(), SelDefaultAffinity);
 }
 
 void DOMSelection::collapseToStart(ExceptionState& exceptionState) {
   if (!isAvailable())
     return;
 
   const VisibleSelection& selection = frame()->selection().selection();
 
   if (selection.isNone()) {
     exceptionState.throwDOMException(InvalidStateError,
                                      "there is no selection.");
     return;
   }
 
+  // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
+  // needs to be audited.  See http://crbug.com/590369 for more details.
+  // In the long term, we should change FrameSelection::setSelection to take a
+  // parameter that does not require clean layout, so that modifying selection
+  // no longer performs synchronous layout by itself.
+  frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();
+
   frame()->selection().moveTo(selection.start(), SelDefaultAffinity);
 }
 
 void DOMSelection::empty() {
   if (!isAvailable())
     return;
   frame()->selection().clear();
 }
 
 void DOMSelection::setBaseAndExtent(Node* baseNode,
@@ skipping 176 matching lines @@
     return;
   }
 
   FrameSelection& selection = frame()->selection();
 
   if (newRange->ownerDocument() != selection.document()) {
     // "editing/selection/selection-in-iframe-removed-crash.html" goes here.
     return;
   }
 
+  // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
+  // needs to be audited.  See http://crbug.com/590369 for more details.
+  // In the long term, we should change FrameSelection::setSelection to take a
+  // parameter that does not require clean layout, so that modifying selection
+  // no longer performs synchronous layout by itself.
+  frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();

[Xiaocheng, 2016/10/04 01:01:40]

Originally, DOMSelection::addRange doesn't trigger layout if it fails. This
patch makes layout triggered in more cases. Do we mind that?

[yosin_UTC9, 2016/10/04 01:52:06]

Upon failure, we don't grantee state. So, it should be OK to update layout tree.

+
   if (selection.isNone()) {
     selection.setSelectedRange(newRange, VP_DEFAULT_AFFINITY);
     return;
   }
 
   Range* originalRange = selection.firstRange();
 
   if (originalRange->startContainer()->document() !=
       newRange->startContainer()->document()) {
     addConsoleError(
@@ skipping 179 matching lines @@
     m_treeScope->document().addConsoleMessage(
         ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, message));
 }
 
 DEFINE_TRACE(DOMSelection) {
   visitor->trace(m_treeScope);
   DOMWindowProperty::trace(visitor);
 }
 
 }  // namespace blink