Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2385923002: Tell renderer which subframes have history items on back/forward. (Closed)

Created:
4 years, 2 months ago by Charlie Reis
Modified:
4 years, 2 months ago
Reviewers:
alexmos, dcheng
CC:
chromium-reviews, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Tell renderer which subframes have history items on back/forward. This avoids making an IPC trip to the browser process for frames that will not find a history item there. BUG=649345, 639842 TEST=See bug for repro steps. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2380943002 Cr-Commit-Position: refs/heads/master@{#421972} (cherry picked from commit c8ca51e469c96ab4a3e1b0cd9772687077b38984) Committed: https://chromium.googlesource.com/chromium/src/+/1c99ce14a59e2bc3fc9da83684748315ad5e2023

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -51 lines) Patch
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 chunk +105 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.h View 3 chunks +11 lines, -7 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.cc View 3 chunks +10 lines, -4 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/frame_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/navigation_params.h View 3 chunks +9 lines, -8 lines 0 comments Download
M content/common/navigation_params.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +10 lines, -10 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 5 chunks +12 lines, -15 lines 0 comments Download
A content/test/data/navigation_controller/dynamic_iframe.html View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Charlie Reis
FYI: Merging to M54. (I've compiled and tested locally.)
4 years, 2 months ago (2016-09-30 23:17:10 UTC) #2
Charlie Reis
Committed patchset #1 (id:1) manually as 1c99ce14a59e2bc3fc9da83684748315ad5e2023.
4 years, 2 months ago (2016-10-01 02:55:51 UTC) #4
dcheng
4 years, 2 months ago (2016-10-01 03:24:16 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698