Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Side by Side Diff: content/renderer/render_frame_impl.h

Issue 2385923002: Tell renderer which subframes have history items on back/forward. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/common/navigation_params.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 1072 matching lines...) Expand 10 before | Expand all | Expand 10 after
1083 // Non-null when the RenderFrame is a local root for compositing, input, 1083 // Non-null when the RenderFrame is a local root for compositing, input,
1084 // layout, etc. A local frame is also a local root iff it does not have a 1084 // layout, etc. A local frame is also a local root iff it does not have a
1085 // parent that is a local frame. 1085 // parent that is a local frame.
1086 scoped_refptr<RenderWidget> render_widget_; 1086 scoped_refptr<RenderWidget> render_widget_;
1087 1087
1088 // Temporarily holds state pertaining to a navigation that has been initiated 1088 // Temporarily holds state pertaining to a navigation that has been initiated
1089 // until the NavigationState corresponding to the new navigation is created in 1089 // until the NavigationState corresponding to the new navigation is created in
1090 // didCreateDataSource(). 1090 // didCreateDataSource().
1091 std::unique_ptr<NavigationParams> pending_navigation_params_; 1091 std::unique_ptr<NavigationParams> pending_navigation_params_;
1092 1092
1093 // Keeps track of whether the browser process has any history items that need 1093 // Keeps track of which future subframes the browser process has history items
1094 // to be used for subframes of this frame (in the case of a history 1094 // for during a history navigation. The renderer process should ask the
1095 // navigation). If not, the renderer can skip sending an IPC to the browser 1095 // browser for history items when subframes with these names are created, and
1096 // and directly load any initial URLs for children itself. This state is 1096 // directly load the initial URLs for any other subframes. This state is
1097 // cleared during didStopLoading, since it is not needed after the first load 1097 // incrementally cleared as it is used and then reset in didStopLoading, since
1098 // completes and is never used after the initial navigation. It is inherited 1098 // it is not needed after the first load completes and is never used after the
1099 // by subframes. 1099 // initial navigation.
1100 // TODO(creis): Switch this to a data structure of unique names and 1100 // TODO(creis): Expand this to include any corresponding same-process
1101 // corresponding same-process PageStates in https://crbug.com/639842. 1101 // PageStates for the whole subtree in https://crbug.com/639842.
1102 bool browser_has_subtree_history_items_; 1102 std::set<std::string> history_subframe_unique_names_;
1103 1103
1104 // Stores the current history item for this frame, so that updates to it can 1104 // Stores the current history item for this frame, so that updates to it can
1105 // be reported to the browser process via SendUpdateState. 1105 // be reported to the browser process via SendUpdateState.
1106 blink::WebHistoryItem current_history_item_; 1106 blink::WebHistoryItem current_history_item_;
1107 1107
1108 #if defined(ENABLE_PLUGINS) 1108 #if defined(ENABLE_PLUGINS)
1109 // Current text input composition text. Empty if no composition is in 1109 // Current text input composition text. Empty if no composition is in
1110 // progress. 1110 // progress.
1111 base::string16 pepper_composition_text_; 1111 base::string16 pepper_composition_text_;
1112 1112
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
1293 mojom::FrameHostPtr frame_host_; 1293 mojom::FrameHostPtr frame_host_;
1294 1294
1295 base::WeakPtrFactory<RenderFrameImpl> weak_factory_; 1295 base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
1296 1296
1297 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl); 1297 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
1298 }; 1298 };
1299 1299
1300 } // namespace content 1300 } // namespace content
1301 1301
1302 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 1302 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
OLDNEW
« no previous file with comments | « content/common/navigation_params.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698