Issue 23859002: remove Isolate::Current from most files starting with 'a'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23859002: remove Isolate::Current from most files starting with 'a' (Closed)

Created:
7 years, 3 months ago by dcarney

Modified:
7 years, 3 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

remove Isolate::Current from most files starting with 'a' R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16463

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -37 lines)			Patch
M	src/accessors.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/api.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/api.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/codegen-arm.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/assembler.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ast.h	View	2 chunks	+6 lines, -3 lines	0 comments	Download
M	src/ast.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/codegen.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/full-codegen.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/full-codegen.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/hydrogen.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/codegen-mips.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/prettyprinter.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/prettyprinter.cc	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	src/rewriter.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/typing.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/codegen-x64.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Sven Panne

LGTM. It's a pity that we have to keep the Isolate field in the AST ...

7 years, 3 months ago (2013-09-02 09:23:34 UTC) #2

dcarney

7 years, 3 months ago (2013-09-02 09:27:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r16463 (presubmit successful).