Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: src/accessors.cc

Issue 23859002: remove Isolate::Current from most files starting with 'a' (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/api.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 832 matching lines...) Expand 10 before | Expand all | Expand 10 after
843 return; 843 return;
844 } 844 }
845 context->set(slot, *v8::Utils::OpenHandle(*value)); 845 context->set(slot, *v8::Utils::OpenHandle(*value));
846 } 846 }
847 847
848 848
849 Handle<AccessorInfo> Accessors::MakeModuleExport( 849 Handle<AccessorInfo> Accessors::MakeModuleExport(
850 Handle<String> name, 850 Handle<String> name,
851 int index, 851 int index,
852 PropertyAttributes attributes) { 852 PropertyAttributes attributes) {
853 Factory* factory = name->GetIsolate()->factory(); 853 Isolate* isolate = name->GetIsolate();
854 Factory* factory = isolate->factory();
854 Handle<ExecutableAccessorInfo> info = factory->NewExecutableAccessorInfo(); 855 Handle<ExecutableAccessorInfo> info = factory->NewExecutableAccessorInfo();
855 info->set_property_attributes(attributes); 856 info->set_property_attributes(attributes);
856 info->set_all_can_read(true); 857 info->set_all_can_read(true);
857 info->set_all_can_write(true); 858 info->set_all_can_write(true);
858 info->set_name(*name); 859 info->set_name(*name);
859 info->set_data(Smi::FromInt(index)); 860 info->set_data(Smi::FromInt(index));
860 Handle<Object> getter = v8::FromCData(&ModuleGetExport); 861 Handle<Object> getter = v8::FromCData(isolate, &ModuleGetExport);
861 Handle<Object> setter = v8::FromCData(&ModuleSetExport); 862 Handle<Object> setter = v8::FromCData(isolate, &ModuleSetExport);
862 info->set_getter(*getter); 863 info->set_getter(*getter);
863 if (!(attributes & ReadOnly)) info->set_setter(*setter); 864 if (!(attributes & ReadOnly)) info->set_setter(*setter);
864 return info; 865 return info;
865 } 866 }
866 867
867 868
868 } } // namespace v8::internal 869 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698