Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2385793003: DevTools: Fix visible whitespace for cm_modes (Closed)

Created:
4 years, 2 months ago by einbinder
Modified:
4 years, 2 months ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Fix visible whitespace for cm_modes BUG=none Committed: https://crrev.com/34b6f744f635276954acd40f32a97dd49bee2f5a Cr-Commit-Position: refs/heads/master@{#422928}

Patch Set 1 #

Patch Set 2 : Use promises #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -33 lines) Patch
M third_party/WebKit/LayoutTests/inspector/editor/php-highlighter.html View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/editor/text-editor-token-at-position.html View 1 1 chunk +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js View 1 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js View 1 4 chunks +5 lines, -26 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
einbinder
C++ fix
4 years, 2 months ago (2016-09-30 23:38:47 UTC) #2
lushnikov
this doesn't make ugly code better.. let's fix it.
4 years, 2 months ago (2016-10-01 00:45:37 UTC) #3
einbinder
Made it nicer. Ptal
4 years, 2 months ago (2016-10-04 18:06:33 UTC) #4
lushnikov
lgtm
4 years, 2 months ago (2016-10-04 19:07:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385793003/20001
4 years, 2 months ago (2016-10-04 19:33:13 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 21:04:53 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 21:06:58 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/34b6f744f635276954acd40f32a97dd49bee2f5a
Cr-Commit-Position: refs/heads/master@{#422928}

Powered by Google App Engine
This is Rietveld 408576698