third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js - Issue 2385793003: DevTools: Fix visible whitespace for cm_modes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js

Issue 2385793003: DevTools: Fix visible whitespace for cm_modes (Closed)

Patch Set: Use promises Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/editor/text-editor-token-at-position.html ('k') | third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js

diff --git a/third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js b/third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js

index ef722dc28ca57fc932a5c44851a890839cf8d99e..b8568d0a386feea5e1bf2f310838c26256a78085 100644

--- a/third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js

+++ b/third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js

@@ -485,11 +485,13 @@ WebInspector.SourcesTextEditor.prototype = {

/**

* @override

* @param {string} mimeType

+ * @return {!Promise}

setMimeType: function(mimeType)

{

this._mimeType = mimeType;

- WebInspector.CodeMirrorTextEditor.prototype.setMimeType.call(this, this._applyWhitespaceMimetype(mimeType));

+ return WebInspector.CodeMirrorTextEditor.prototype.setMimeType.call(this, mimeType)

+ .then(() => this._codeMirror.setOption("mode", this._applyWhitespaceMimetype(mimeType)));

_updateWhitespace: function()