Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 2385693002: chrome/browser/media_galleries/fileapi: Change ScopedTempDir::path() to GetPath() (Closed)

Created:
4 years, 2 months ago by vabr (Chromium)
Modified:
4 years, 2 months ago
Reviewers:
kinuko, Lei Zhang
CC:
chromium-reviews, Lei Zhang, tommycli, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome/browser/media_galleries/fileapi: Change ScopedTempDir::path() to GetPath() path() is being deprecated, GetPath() has better checking against wrong use. For more context, see https://codereview.chromium.org/2275553005/. BUG=640599 TBR=kinuko@chromium.org Committed: https://crrev.com/cdf7fe04bfb42f51e0b72dbec2051895da59d8a6 Cr-Commit-Position: refs/heads/master@{#422117}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/media_galleries/fileapi/picasa_data_provider_browsertest.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
vabr (Chromium)
Hello kinuko@, I put you in TBR for this CL. The two changes here are ...
4 years, 2 months ago (2016-09-30 15:18:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385693002/1
4 years, 2 months ago (2016-09-30 15:18:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 15:24:35 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cdf7fe04bfb42f51e0b72dbec2051895da59d8a6 Cr-Commit-Position: refs/heads/master@{#422117}
4 years, 2 months ago (2016-09-30 15:31:02 UTC) #10
Lei Zhang
4 years, 2 months ago (2016-09-30 15:37:18 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698