Remove ScopedTempDir::path()

Remove ScopedTempDir::path()

path() is deprecated and was replaced by GetPath().

For more context, see https://codereview.chromium.org/2275553005/.

BUG=640599
R=danakj@chromium.org

Committed: https://crrev.com/79877046a7f287cbcf082bb4758081b2ab22075a
Cr-Commit-Position: refs/heads/master@{#422121}

[vabr (Chromium), 2016-09-07 16:09:03]

Hi danakj@,

Please review the //base change here.

I still need to land 15 CLs before I can land this one, so a lot of rebasing is
going to happen, but the //base change should stay the same.

Cheers,
Vaclav

[danakj, 2016-09-07 21:34:27]

LGTM

[danakj, 2016-09-09 01:50:45]

On 2016/09/07 16:09:03, vabr (Chromium) wrote:
> Hi danakj@,
> 
> Please review the //base change here.
> 
> I still need to land 15 CLs before I can land this one, so a lot of rebasing
is
> going to happen, but the //base change should stay the same.

FWIW you should probably just TBR the other CLs, and combine them at will and
TBR a src/OWNERS person for them. Hope that makes things easier.

[vabr (Chromium), 2016-09-09 09:00:35]

On 2016/09/09 01:50:45, danakj wrote:
> On 2016/09/07 16:09:03, vabr (Chromium) wrote:
> > Hi danakj@,
> > 
> > Please review the //base change here.
> > 
> > I still need to land 15 CLs before I can land this one, so a lot of rebasing
> is
> > going to happen, but the //base change should stay the same.
> 
> FWIW you should probably just TBR the other CLs, and combine them at will and
> TBR a src/OWNERS person for them. Hope that makes things easier.

Thanks!

My strategy so far is to wait for reviews in cases where I actually had to fix
unittests (such as in https://codereview.chromium.org/2318023002/). Chunking
this into 15 CLs also helps me to handle the test
failures step by step. If I get blocked on a trivial owners review, I will TBR.

Cheers,
Vaclav

[vabr (Chromium), 2016-09-15 17:26:36]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 17:26:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 17:42:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 17:42:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[vabr (Chromium), 2016-09-15 20:02:12]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 20:02:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 20:21:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 20:21:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vabr (Chromium), 2016-09-30 10:02:54]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 10:03:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 10:20:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 10:20:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vabr (Chromium), 2016-09-30 11:31:08]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 11:31:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 11:57:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 11:57:42]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[vabr (Chromium), 2016-09-30 12:13:10]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 12:13:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 12:51:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 12:51:47]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[vabr (Chromium), 2016-09-30 13:01:38]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 13:01:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 13:49:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 13:49:27]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-09-30 15:32:26]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2016-09-30 15:32:26]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2321603002/#ps120001
(title: "Just rebased")

[commit-bot: I haz the power, 2016-09-30 15:32:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 15:39:48]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-09-30 15:44:08]

Description was changed from

==========
Remove ScopedTempDir::path()

path() is deprecated and was replaced by GetPath().

For more context, see https://codereview.chromium.org/2275553005/.

BUG=640599
R=danakj@chromium.org
==========

to

==========
Remove ScopedTempDir::path()

path() is deprecated and was replaced by GetPath().

For more context, see https://codereview.chromium.org/2275553005/.

BUG=640599
R=danakj@chromium.org

Committed: https://crrev.com/79877046a7f287cbcf082bb4758081b2ab22075a
Cr-Commit-Position: refs/heads/master@{#422121}
==========

[commit-bot: I haz the power, 2016-09-30 15:44:09]

Patchset 7 (id:??) landed as
https://crrev.com/79877046a7f287cbcf082bb4758081b2ab22075a
Cr-Commit-Position: refs/heads/master@{#422121}