Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2385613002: Mac Page Info constants: Use common Chrome comment heading style. (Closed)

Created:
4 years, 2 months ago by lgarron
Modified:
4 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac Page Info constants: Use common Chrome comment heading style. BUG= Committed: https://crrev.com/df2d7edea6071cd8cb1d9d512b60988bee6d834c Cr-Commit-Position: refs/heads/master@{#422658}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
lgarron
avi@, could you review? This is an update to the comment style I introduced in ...
4 years, 2 months ago (2016-09-30 05:21:18 UTC) #3
Avi (use Gerrit)
lgtm
4 years, 2 months ago (2016-09-30 05:50:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385613002/1
4 years, 2 months ago (2016-10-04 01:03:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 01:34:21 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 01:37:41 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df2d7edea6071cd8cb1d9d512b60988bee6d834c
Cr-Commit-Position: refs/heads/master@{#422658}

Powered by Google App Engine
This is Rietveld 408576698