Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2385553002: Revert of Lock down the registration of blob:chrome-extension:// URLs (Closed)

Created:
4 years, 2 months ago by tsergeant
Modified:
4 years, 2 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, extensions-reviews_chromium.org, jam, loading-reviews_chromium.org, mmenke, Randy Smith (Not in Mondays), site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Lock down the registration of blob:chrome-extension:// URLs (patchset #13 id:230001 of https://codereview.chromium.org/2364633004/ ) Reason for revert: Speculative revert to fix failing test http/tests/xmlhttprequest/xhr-to-blob-in-isolated-world.html in webkit_tests. See failures in: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/46369 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/24388 Original issue's description: > Update ChildProcessSecurityPolicy so that the chrome-extension:// scheme > is considered "web safe" to be requestable from any process, but only > "web safe" to commit in extension processes. > > In ChildProcessSecurityPolicy::CanRequestURL and CanCommitURL, when > seeing blob and filesystem urls, make a security decision based > on the inner origin rather than the scheme. > > When the extensions ProcessManager (via ExtensionWebContentsObserver) notices a > RenderFrame being created in an extension SiteInstance, grant that process > permission to commit chrome-extension:// URLs. > > In BlobDispatcherHost, only allow creation of blob URLs from processes that > would be able to commit them. > > Add a security exploit browsertest that verifies the above mechanisms working > together. > > BUG=644966 > > Committed: https://crrev.com/a411fd062bc68fc2b5fc3aca7e4cbb8e4a3e074e > Cr-Commit-Position: refs/heads/master@{#421964} TBR=reillyg@chromium.org,creis@chromium.org,thestig@chromium.org,rdevlin.cronin@chromium.org,nick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=644966 Committed: https://crrev.com/bd3b7a4c91c8dc7a28e197c3a88a2885121c3042 Cr-Commit-Position: refs/heads/master@{#421997}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -359 lines) Patch
M chrome/browser/DEPS View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 2 chunks +4 lines, -17 lines 0 comments Download
M chrome/browser/chrome_security_exploit_browsertest.cc View 4 chunks +10 lines, -56 lines 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 1 chunk +0 lines, -72 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/extensions/process_manager_browsertest.cc View 2 chunks +0 lines, -43 lines 0 comments Download
M content/browser/bad_message.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/blob_storage/blob_dispatcher_host.cc View 1 chunk +1 line, -12 lines 0 comments Download
M content/browser/child_process_security_policy_impl.h View 4 chunks +14 lines, -10 lines 0 comments Download
M content/browser/child_process_security_policy_impl.cc View 8 chunks +19 lines, -83 lines 0 comments Download
M content/public/browser/child_process_security_policy.h View 2 chunks +2 lines, -37 lines 0 comments Download
M extensions/browser/extension_web_contents_observer.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
tsergeant
Created Revert of Lock down the registration of blob:chrome-extension:// URLs
4 years, 2 months ago (2016-09-30 00:40:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385553002/1
4 years, 2 months ago (2016-09-30 00:41:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 00:42:40 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 00:45:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd3b7a4c91c8dc7a28e197c3a88a2885121c3042
Cr-Commit-Position: refs/heads/master@{#421997}

Powered by Google App Engine
This is Rietveld 408576698