components/subresource_filter/core/common/indexed_ruleset.cc - Issue 2385533002: Replace usage of GURL(origin.Serialize()) with origin.GetURL()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/core/common/indexed_ruleset.cc

Issue 2385533002: Replace usage of GURL(origin.Serialize()) with origin.GetURL() (Closed)

Patch Set: rebase and fix up some includes Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/subresource_filter/core/common/indexed_ruleset.cc

diff --git a/components/subresource_filter/core/common/indexed_ruleset.cc b/components/subresource_filter/core/common/indexed_ruleset.cc

index 58985d85616aa14680a2680ef7cbd2c5324acdb2..307720e153a0f6af7d6738ef5b567bd4c64adc5a 100644

--- a/components/subresource_filter/core/common/indexed_ruleset.cc

+++ b/components/subresource_filter/core/common/indexed_ruleset.cc

@@ -362,7 +362,7 @@ bool IsThirdPartyUrl(const GURL& url, const url::Origin& first_party_origin) {

// TODO(pkalinnikov): Avoid converting Origin to GURL.

return first_party_origin.unique() ||

!net::registry_controlled_domains::SameDomainOrHost(

- url, GURL(first_party_origin.Serialize()),

+ url, first_party_origin.GetURL(),

net::registry_controlled_domains::INCLUDE_PRIVATE_REGISTRIES);

}