ios/web/public/origin_util.mm - Issue 2385533002: Replace usage of GURL(origin.Serialize()) with origin.GetURL()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/public/origin_util.mm

Issue 2385533002: Replace usage of GURL(origin.Serialize()) with origin.GetURL() (Closed)

Patch Set: rebase and fix up some includes Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/public/origin_util.mm

diff --git a/ios/web/public/origin_util.mm b/ios/web/public/origin_util.mm

index 96ed012d62ed5ab46f44c24918564873dc1f6ac1..a0d8e14ffb3f756ae31f8ac444879f1bff4964e7 100644

--- a/ios/web/public/origin_util.mm

+++ b/ios/web/public/origin_util.mm

@@ -41,7 +41,7 @@ GURL GURLOriginWithWKSecurityOrigin(WKSecurityOrigin* origin) {

url::SchemeHostPort origin_tuple(base::SysNSStringToUTF8(origin.protocol),

base::SysNSStringToUTF8(origin.host),

base::checked_cast<uint16_t>(origin.port));

- return GURL(origin_tuple.Serialize());

+ return origin_tuple.GetURL();

sdefresne 2016/10/04 10:59:33 It look like this code broke the iOS bots with a f

Charlie Harrison 2016/10/04 12:15:22 Yup, I think this indicates problems with the depe

}

} // namespace web