Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1217)

Unified Diff: content/browser/frame_host/render_widget_host_view_guest.h

Issue 2385333002: RenderWidgetHostViewChildFrame's called a virtual in its ctor. (Closed)
Patch Set: Move guest ctor to private Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_widget_host_view_guest.h
diff --git a/content/browser/frame_host/render_widget_host_view_guest.h b/content/browser/frame_host/render_widget_host_view_guest.h
index bf829fed772f0eaa8c6e898c9935dc350c6620d6..10c0ad42c875e04138ef7830f1e47ac08bd12540 100644
--- a/content/browser/frame_host/render_widget_host_view_guest.h
+++ b/content/browser/frame_host/render_widget_host_view_guest.h
@@ -45,7 +45,7 @@ class CONTENT_EXPORT RenderWidgetHostViewGuest
: public RenderWidgetHostViewChildFrame,
public ui::GestureConsumer {
public:
- RenderWidgetHostViewGuest(
+ static RenderWidgetHostViewGuest* Create(
RenderWidgetHost* widget,
BrowserPluginGuest* guest,
base::WeakPtr<RenderWidgetHostViewBase> platform_view);
@@ -132,6 +132,11 @@ class CONTENT_EXPORT RenderWidgetHostViewGuest
friend class RenderWidgetHostView;
private:
+ RenderWidgetHostViewGuest(
+ RenderWidgetHost* widget,
+ BrowserPluginGuest* guest,
+ base::WeakPtr<RenderWidgetHostViewBase> platform_view);
+
RenderWidgetHostViewBase* GetOwnerRenderWidgetHostView() const;
// Since we now route GestureEvents directly to the guest renderer, we need

Powered by Google App Engine
This is Rietveld 408576698