content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc - Issue 2385333002: RenderWidgetHostViewChildFrame's called a virtual in its ctor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

Issue 2385333002: RenderWidgetHostViewChildFrame's called a virtual in its ctor. (Closed)

Patch Set: Move guest ctor to private Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_widget_host_view_child_frame.cc ('k') | content/browser/frame_host/render_widget_host_view_guest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

diff --git a/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc b/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

index 685e7bd7d437b6b16715d43e21630ffe75c42d37..4d38f70ca76377c481a5a046b27c4046316455cd 100644

--- a/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

+++ b/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

@@ -96,7 +96,7 @@ class RenderWidgetHostViewChildFrameTest : public testing::Test {

int32_t routing_id = process_host->GetNextRoutingID();

widget_host_ =

new RenderWidgetHostImpl(&delegate_, process_host, routing_id, false);

- view_ = new RenderWidgetHostViewChildFrame(widget_host_);

+ view_ = RenderWidgetHostViewChildFrame::Create(widget_host_);

test_frame_connector_ = new MockCrossProcessFrameConnector();

view_->SetCrossProcessFrameConnector(test_frame_connector_);