content/browser/frame_host/render_widget_host_view_child_frame.h - Issue 2385333002: RenderWidgetHostViewChildFrame's called a virtual in its ctor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.h

Issue 2385333002: RenderWidgetHostViewChildFrame's called a virtual in its ctor. (Closed)

Patch Set: Fix some failures in the tests Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/render_widget_host_view_child_frame.h

diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.h b/content/browser/frame_host/render_widget_host_view_child_frame.h

index 8993a5a63c4c9418f75d5a6b297664b7de3d9cde..127073bf92e43c2ea8df3bb09c364c29d459aef0 100644

--- a/content/browser/frame_host/render_widget_host_view_child_frame.h

+++ b/content/browser/frame_host/render_widget_host_view_child_frame.h

@@ -52,8 +52,12 @@ class CONTENT_EXPORT RenderWidgetHostViewChildFrame

: public RenderWidgetHostViewBase,

public cc::SurfaceFactoryClient,

public cc::BeginFrameObserver {

- public:

+ protected:

clamy 2016/10/05 12:35:53 Please move the protected part of the header betwe

dtapuska 2016/10/05 14:25:00 Done.

explicit RenderWidgetHostViewChildFrame(RenderWidgetHost* widget);

+ void Init();

+ public:

+ static RenderWidgetHostViewChildFrame* Create(RenderWidgetHost* widget);

~RenderWidgetHostViewChildFrame() override;

void SetCrossProcessFrameConnector(