Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Side by Side Diff: content/browser/frame_host/render_widget_host_view_child_frame.h

Issue 2385333002: RenderWidgetHostViewChildFrame's called a virtual in its ctor. (Closed)
Patch Set: Fix some failures in the tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 // content that is embedding it. This is not a platform-specific class; rather, 45 // content that is embedding it. This is not a platform-specific class; rather,
46 // the embedding renderer process implements the platform containing the 46 // the embedding renderer process implements the platform containing the
47 // widget, and the top-level frame's RenderWidgetHostView will ultimately 47 // widget, and the top-level frame's RenderWidgetHostView will ultimately
48 // manage all native widget interaction. 48 // manage all native widget interaction.
49 // 49 //
50 // See comments in render_widget_host_view.h about this class and its members. 50 // See comments in render_widget_host_view.h about this class and its members.
51 class CONTENT_EXPORT RenderWidgetHostViewChildFrame 51 class CONTENT_EXPORT RenderWidgetHostViewChildFrame
52 : public RenderWidgetHostViewBase, 52 : public RenderWidgetHostViewBase,
53 public cc::SurfaceFactoryClient, 53 public cc::SurfaceFactoryClient,
54 public cc::BeginFrameObserver { 54 public cc::BeginFrameObserver {
55 protected:
clamy 2016/10/05 12:35:53 Please move the protected part of the header betwe
dtapuska 2016/10/05 14:25:00 Done.
56 explicit RenderWidgetHostViewChildFrame(RenderWidgetHost* widget);
57 void Init();
58
55 public: 59 public:
56 explicit RenderWidgetHostViewChildFrame(RenderWidgetHost* widget); 60 static RenderWidgetHostViewChildFrame* Create(RenderWidgetHost* widget);
57 ~RenderWidgetHostViewChildFrame() override; 61 ~RenderWidgetHostViewChildFrame() override;
58 62
59 void SetCrossProcessFrameConnector( 63 void SetCrossProcessFrameConnector(
60 CrossProcessFrameConnector* frame_connector); 64 CrossProcessFrameConnector* frame_connector);
61 65
62 // This functions registers single-use callbacks that want to be notified when 66 // This functions registers single-use callbacks that want to be notified when
63 // the next frame is swapped. The callback is triggered by 67 // the next frame is swapped. The callback is triggered by
64 // OnSwapCompositorFrame, which is the appropriate time to request pixel 68 // OnSwapCompositorFrame, which is the appropriate time to request pixel
65 // readback for the frame that is about to be drawn. Once called, the callback 69 // readback for the frame that is about to be drawn. Once called, the callback
66 // pointer is released. 70 // pointer is released.
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 // The surface client ID of the parent RenderWidgetHostView. 0 if none. 252 // The surface client ID of the parent RenderWidgetHostView. 0 if none.
249 cc::FrameSinkId parent_frame_sink_id_; 253 cc::FrameSinkId parent_frame_sink_id_;
250 254
251 base::WeakPtrFactory<RenderWidgetHostViewChildFrame> weak_factory_; 255 base::WeakPtrFactory<RenderWidgetHostViewChildFrame> weak_factory_;
252 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewChildFrame); 256 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewChildFrame);
253 }; 257 };
254 258
255 } // namespace content 259 } // namespace content
256 260
257 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_ 261 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698