Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.cc

Issue 2385333002: RenderWidgetHostViewChildFrame's called a virtual in its ctor. (Closed)
Patch Set: Fix some failures in the tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_widget_host_view_child_frame.cc
diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.cc b/content/browser/frame_host/render_widget_host_view_child_frame.cc
index 8c3d1c4cf53a020d08874634b787b610ea431c44..c8ffd098009b451ddaa7b9ed8bd5441623708fb2 100644
--- a/content/browser/frame_host/render_widget_host_view_child_frame.cc
+++ b/content/browser/frame_host/render_widget_host_view_child_frame.cc
@@ -39,6 +39,14 @@
namespace content {
+RenderWidgetHostViewChildFrame* RenderWidgetHostViewChildFrame::Create(
clamy 2016/10/05 12:35:53 Please add a // static comment above the method.
dtapuska 2016/10/05 14:25:00 Done.
+ RenderWidgetHost* widget) {
+ RenderWidgetHostViewChildFrame* view =
+ new RenderWidgetHostViewChildFrame(widget);
+ view->Init();
+ return view;
+}
+
RenderWidgetHostViewChildFrame::RenderWidgetHostViewChildFrame(
RenderWidgetHost* widget_host)
: host_(RenderWidgetHostImpl::From(widget_host)),
@@ -54,7 +62,6 @@ RenderWidgetHostViewChildFrame::RenderWidgetHostViewChildFrame(
GetSurfaceManager()->RegisterFrameSinkId(frame_sink_id_);
RegisterFrameSinkId();
- host_->SetView(this);
GetTextInputManager();
kenrb 2016/10/05 14:10:40 Would it make sense to move these other method cal
dtapuska 2016/10/05 14:25:00 done.
}
@@ -66,6 +73,10 @@ RenderWidgetHostViewChildFrame::~RenderWidgetHostViewChildFrame() {
GetSurfaceManager()->InvalidateFrameSinkId(frame_sink_id_);
}
+void RenderWidgetHostViewChildFrame::Init() {
+ host_->SetView(this);
+}
+
void RenderWidgetHostViewChildFrame::SetCrossProcessFrameConnector(
CrossProcessFrameConnector* frame_connector) {
if (frame_connector_ == frame_connector)

Powered by Google App Engine
This is Rietveld 408576698