Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2385323004: relnote: change ExtractContentLengthFromHeaders to return false if content-length is missing. If th… (Closed)

Created:
4 years, 2 months ago by Zhongyi Shi
Modified:
4 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

relnote: change ExtractContentLengthFromHeaders to return false if content-length is missing. If the caller is tolerate to have content-length header missing, it should call ExtractContentLengthFromHeaders only when content-length header is present. Merge internal change: 135027159 BUG= Committed: https://crrev.com/34b14f3281e01845d9ef7cf5512855a417798370 Cr-Commit-Position: refs/heads/master@{#422642}

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -26 lines) Patch
M net/quic/core/spdy_utils.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/quic/core/spdy_utils.cc View 1 3 chunks +30 lines, -23 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Zhongyi Shi
4 years, 2 months ago (2016-10-03 22:13:39 UTC) #3
Ryan Hamilton
lgtm
4 years, 2 months ago (2016-10-03 22:15:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385323004/1
4 years, 2 months ago (2016-10-03 22:16:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/41579)
4 years, 2 months ago (2016-10-03 22:54:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385323004/20001
4 years, 2 months ago (2016-10-03 23:11:34 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 00:53:38 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 00:55:22 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/34b14f3281e01845d9ef7cf5512855a417798370
Cr-Commit-Position: refs/heads/master@{#422642}

Powered by Google App Engine
This is Rietveld 408576698