relnote: change ExtractContentLengthFromHeaders to return false if content-length is missing. If th…

net/quic/core/spdy_utils.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_QUIC_SPDY_UTILS_H_
 #define NET_QUIC_SPDY_UTILS_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 16 matching lines @@
   // Parses |data| as a std::string containing serialized HTTP/2 HEADERS frame,
   // populating |headers| with the key->value std:pairs found.
   // |content_length| will be populated with the value of the content-length
   // header if one or more are present.
   // Returns true on success, false if parsing fails, or invalid keys are found.
   static bool ParseHeaders(const char* data,
                            uint32_t data_len,
                            int64_t* content_length,
                            SpdyHeaderBlock* headers);
 
-  // Populate |content length| with the value of the content-length header if
-  // one or more are present in the headers. Returns true on success, false if
-  // parsing fails.
+  // Populate |content length| with the value of the content-length header.
+  // Returns true on success, false if parsing fails or content-length header is
+  // missing.
   static bool ExtractContentLengthFromHeaders(int64_t* content_length,
                                               SpdyHeaderBlock* headers);
 
   // Parses |data| as a std::string containing serialized HTTP/2 HEADERS frame,
   // populating |trailers| with the key->value std:pairs found.
   // The final offset header will be excluded from |trailers|, and instead the
   // value will be copied to |final_byte_offset|.
   // Returns true on success, false if parsing fails, or invalid keys are found.
   static bool ParseTrailers(const char* data,
                             uint32_t data_len,
@@ skipping 28 matching lines @@
   static bool PopulateHeaderBlockFromUrl(const std::string url,
                                          SpdyHeaderBlock* headers);
 
  private:
   DISALLOW_COPY_AND_ASSIGN(SpdyUtils);
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_SPDY_UTILS_H_