Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2385303002: Rename CFX_WeakPtr::Clear() to DestroyObject() (Closed)

Created:
4 years, 2 months ago by Tom Sepez
Modified:
4 years, 2 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename CFX_WeakPtr::Clear() to DestroyObject() |Clear| is too easily mistaken for "clear this pointer only." Committed: https://pdfium.googlesource.com/pdfium/+/abab61a1fcd776964a15c528dd2dd034fb31edf0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M core/fpdfapi/fpdf_parser/cfdf_document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcrt/cfx_weak_ptr.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcrt/cfx_weak_ptr_unittest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Tom Sepez
Dan, for review. rename only, no functional change
4 years, 2 months ago (2016-10-03 19:22:22 UTC) #5
dsinclair
lgtm
4 years, 2 months ago (2016-10-03 19:26:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385303002/1
4 years, 2 months ago (2016-10-03 20:54:13 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 20:54:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/abab61a1fcd776964a15c528dd2dd034fb31...

Powered by Google App Engine
This is Rietveld 408576698