core/fxcrt/cfx_weak_ptr.h - Issue 2385303002: Rename CFX_WeakPtr::Clear() to DestroyObject()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcrt/cfx_weak_ptr.h

Issue 2385303002: Rename CFX_WeakPtr::Clear() to DestroyObject() (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: core/fxcrt/cfx_weak_ptr.h

diff --git a/core/fxcrt/cfx_weak_ptr.h b/core/fxcrt/cfx_weak_ptr.h

index 61f15e3ddaa6eb2f95194186ba7074bb52855a70..9ac1475884d0f0f9b7194f118d4845e38fd25dbd 100644

--- a/core/fxcrt/cfx_weak_ptr.h

+++ b/core/fxcrt/cfx_weak_ptr.h

@@ -35,7 +35,7 @@ class CFX_WeakPtr {

bool operator!=(const CFX_WeakPtr& that) const { return !(*this == that); }

T* Get() const { return m_pHandle ? m_pHandle->Get() : nullptr; }

- void Clear() {

+ void DeleteObject() {

if (m_pHandle) {

m_pHandle->Clear();

m_pHandle.Reset();

« no previous file with comments | « core/fpdfapi/fpdf_parser/cpdf_document.cpp ('k') | core/fxcrt/cfx_weak_ptr_unittest.cpp » ('j') | no next file with comments »