Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2385293002: Make CPDF_Object containers hold objects via unique pointers (Closed)

Created:
4 years, 2 months ago by Tom Sepez
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make CPDF_Object containers hold objects via unique pointers. This tweaks the implementation while leaving the API the same. The API change is more disruptive, so break this part off first. Committed: https://pdfium.googlesource.com/pdfium/+/1d023881cd53485303c0fcc0b5878e700dc470fd

Patch Set 1 #

Patch Set 2 : better iterator in clone #

Patch Set 3 : fixit #

Patch Set 4 : Rebase #

Patch Set 5 : Remove duplicated line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -104 lines) Patch
M core/fpdfapi/edit/fpdf_edit_create.cpp View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfapi/page/cpdf_allstates.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/page/cpdf_colorspace.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/page/fpdf_page_parser.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_array.h View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M core/fpdfapi/parser/cpdf_array.cpp View 1 2 3 7 chunks +19 lines, -25 lines 0 comments Download
M core/fpdfapi/parser/cpdf_data_avail.cpp View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfapi/parser/cpdf_dictionary.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/parser/cpdf_dictionary.cpp View 1 2 3 4 chunks +21 lines, -43 lines 0 comments Download
M core/fpdfapi/parser/cpdf_object_unittest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_parser.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_reference.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M core/fpdfapi/parser/cpdf_stream.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/fpdf_parser_utility.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpdf_formcontrol.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfdoc/cpdf_formfield.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpdf_interform.cpp View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/formfiller/cba_fontmap.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_flatten.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_transformpage.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfppo.cpp View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/Document.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fontmgr.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
Tom Sepez
Lei, for review.
4 years, 2 months ago (2016-10-13 23:05:46 UTC) #9
Lei Zhang
lgtm
4 years, 2 months ago (2016-10-13 23:19:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385293002/80001
4 years, 2 months ago (2016-10-13 23:28:03 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 23:36:24 UTC) #14
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/1d023881cd53485303c0fcc0b5878e700dc4...

Powered by Google App Engine
This is Rietveld 408576698