fpdfsdk/fpdf_transformpage.cpp - Issue 2385293002: Make CPDF_Object containers hold objects via unique pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdf_transformpage.cpp

Issue 2385293002: Make CPDF_Object containers hold objects via unique pointers (Closed)

Patch Set: Remove duplicated line Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fpdf_transformpage.cpp

diff --git a/fpdfsdk/fpdf_transformpage.cpp b/fpdfsdk/fpdf_transformpage.cpp

index dfaebd3143905104522ae4847046a9b255dcdc32..47b6cec9ea85908936aa64c9db15b60e9990e5e4 100644

--- a/fpdfsdk/fpdf_transformpage.cpp

+++ b/fpdfsdk/fpdf_transformpage.cpp

@@ -172,7 +172,7 @@ DLLEXPORT FPDF_BOOL STDCALL FPDFPage_TransFormWithClip(FPDF_PAGE page,

CPDF_Dictionary* pPattenDict = pRes->GetDictFor("Pattern");

if (pPattenDict) {

for (const auto& it : *pPattenDict) {

- CPDF_Object* pObj = it.second;

+ CPDF_Object* pObj = it.second.get();

if (pObj->IsReference())

pObj = pObj->GetDirect();

« no previous file with comments | « fpdfsdk/fpdf_flatten.cpp ('k') | fpdfsdk/fpdfppo.cpp » ('j') | no next file with comments »