[Signin] Add account check timeout alert dialogue

Add account check timeout alert dialogue

BUG=650121

[gogerald1, 2016-10-03 22:03:36]

Description was changed from

==========
head


head


add timeout dialog for managed account check

BUG=
==========

to

==========
Add managed account check timeout dialogue during sign in

BUG=650121
==========

[gogerald1, 2016-10-03 22:53:09]

Patchset #1 (id:1) has been deleted

[gogerald1, 2016-10-03 22:53:24]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[gogerald1, 2016-10-03 22:53:48]

Description was changed from

==========
Add managed account check timeout dialogue during sign in

BUG=650121
==========

to

==========
Add account check timeout dialogue during sign in

BUG=650121
==========

[commit-bot: I haz the power, 2016-10-03 22:54:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2016-10-03 22:54:27]

Description was changed from

==========
Add account check timeout dialogue during sign in

BUG=650121
==========

to

==========
Add account check timeout alert dialogue

BUG=650121
==========

[gogerald1, 2016-10-03 22:55:02]

gogerald@chromium.org changed reviewers:
+ bauerb@chromium.org

[gogerald1, 2016-10-03 22:55:03]

Hi, PTAL,

[gogerald1, 2016-10-03 22:59:47]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 23:00:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 00:19:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 00:19:12]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-10-04 10:11:02]

https://codereview.chromium.org/2385273003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachine.java
(right):

https://codereview.chromium.org/2385273003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachine.java:211:
if (mNewAccountManaged.isFulfilled()) {
You're polling the state of the Promise? Don't poll the state of the Promise. :)
It should be sufficient to schedule a delayed task (with
ThreadUtils.postOnUiThreadDelayed) that shows the dialog if the promise is not
fulfilled at that point. (Maybe store the promise in a final local variable
before you reference it in the callback, so you know it's always going to be the
same one).

https://codereview.chromium.org/2385273003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachine.java:241:
timingAccountCheck();
Oh, so "retry" doesn't actually abort the sign-in attempt and restart it, but
just extends the waiting time? Hmm, if this is in fact due to, say, a stuck
network connection, an actual retry might be more useful.