Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2385123003: Rewrap comments to 80 columns in Source/platform/graphics/paint/. (Closed)

Created:
4 years, 2 months ago by Peter Kasting
Modified:
4 years, 2 months ago
Reviewers:
Stephen Chennney
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrap comments to 80 columns in Source/platform/graphics/paint/. This also makes some minor modifications (rewrite for clarity, etc.). BUG=563793 TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/980f63ea8f6c7b647e6cdd7e773903fc536ec1a5 Cr-Commit-Position: refs/heads/master@{#423031}

Patch Set 1 #

Patch Set 2 : Resync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+380 lines, -276 lines) Patch
M third_party/WebKit/Source/platform/graphics/paint/ClipPathDisplayItem.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/CompositingRecorder.cpp View 2 chunks +11 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h View 4 chunks +29 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h View 4 chunks +36 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp View 2 chunks +15 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.h View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h View 1 3 chunks +64 lines, -52 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp View 1 5 chunks +12 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTest.cpp View 1 6 chunks +16 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvasTest.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintChunk.h View 2 chunks +11 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintChunkTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.h View 1 7 chunks +47 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 1 18 chunks +51 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp View 12 chunks +37 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ScopedPaintChunkProperties.h View 2 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.h View 2 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/SubsequenceRecorder.h View 1 chunk +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/SubsequenceRecorder.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
Peter Kasting
4 years, 2 months ago (2016-10-04 07:17:49 UTC) #3
Stephen Chennney
lgtm. Sorry for the slow review.
4 years, 2 months ago (2016-10-05 00:15:19 UTC) #12
Peter Kasting
On 2016/10/05 00:15:19, Stephen Chennney wrote: > lgtm. Sorry for the slow review. Less than ...
4 years, 2 months ago (2016-10-05 01:00:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385123003/20001
4 years, 2 months ago (2016-10-05 01:00:52 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-05 01:07:27 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 01:08:59 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/980f63ea8f6c7b647e6cdd7e773903fc536ec1a5
Cr-Commit-Position: refs/heads/master@{#423031}

Powered by Google App Engine
This is Rietveld 408576698