Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1434)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/permissions/permission_request_impl.h

Issue 2385063005: Make PermissionRequest::GetIconId return different types (Closed)
Patch Set: android Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc ('K') | « chrome/browser/permissions/permission_request.cc ('k') | chrome/browser/permissions/permission_request_impl.cc » ('j') | chrome/browser/permissions/permission_request_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_request_impl.h
diff --git a/chrome/browser/permissions/permission_request_impl.h b/chrome/browser/permissions/permission_request_impl.h
index 45c216a54790388149e27929fd04dca1415492c7..7ab94db7df160b5fca877f1d3a8890ed60293530 100644
--- a/chrome/browser/permissions/permission_request_impl.h
+++ b/chrome/browser/permissions/permission_request_impl.h
@@ -37,10 +37,7 @@ class PermissionRequestImpl : public PermissionRequest {
private:
// PermissionRequest:
- gfx::VectorIconId GetVectorIconId() const override;
-#if defined(OS_ANDROID)
- int GetIconId() const override;
-#endif
+ IconId GetIconId() const override;
base::string16 GetMessageTextFragment() const override;
GURL GetOrigin() const override;
// Remember to call RegisterActionTaken for these methods if you are
« chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc ('K') | « chrome/browser/permissions/permission_request.cc ('k') | chrome/browser/permissions/permission_request_impl.cc » ('j') | chrome/browser/permissions/permission_request_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698