chrome/browser/media/webrtc/media_stream_capture_indicator.cc - Issue 2385063005: Make PermissionRequest::GetIconId return different types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/webrtc/media_stream_capture_indicator.cc

Issue 2385063005: Make PermissionRequest::GetIconId return different types (Closed)

Patch Set: android Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/media/webrtc/media_stream_capture_indicator.cc

diff --git a/chrome/browser/media/webrtc/media_stream_capture_indicator.cc b/chrome/browser/media/webrtc/media_stream_capture_indicator.cc

index 9e809839325b0fcb0e652f6b27f5d86bd981edcf..d97d9c6961d58703d6b3b99d5f4ee75311e5e980 100644

--- a/chrome/browser/media/webrtc/media_stream_capture_indicator.cc

+++ b/chrome/browser/media/webrtc/media_stream_capture_indicator.cc

@@ -356,6 +356,7 @@ void MediaStreamCaptureIndicator::MaybeCreateStatusTrayIcon(bool audio,

void MediaStreamCaptureIndicator::EnsureStatusTrayIconResources() {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

+ // TODO(estade): these should use vector icons.

if (!mic_image_) {

mic_image_ = ResourceBundle::GetSharedInstance().GetImageSkiaNamed(

IDR_INFOBAR_MEDIA_STREAM_MIC);