Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1092)

Issue 2385053002: Revert of Check that all shared workers are terminated. (patchset #2 id:170001 of https://c… (Closed)

Created:
4 years, 2 months ago by falken
Modified:
4 years, 2 months ago
Reviewers:
jam, horo
CC:
chromium-reviews, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Check that all shared workers are terminated. (patchset #2 id:170001 of https://c… (patchset #1 id:1 of https://codereview.chromium.org/2364113003/ ) Reason for revert: These temporary CHECKs can be removed because they are passing on Canary. Original issue's description: > Reland of Check that all shared workers are terminated. (patchset #2 id:170001 of https://c… (patchset #1 id:1 of https://codereview.chromium.org/2338113002/ ) > > Reason for revert: > Relanding after the attempted fix in https://crrev.com/04a6912a1a2b77faf61e4b2514b9ecff74ee1f21 > TBR=horo@chromium.org,jam@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=636377 Committed: https://crrev.com/eb3de882fc78dd4604a2dfb6b2a106da127c4ae1 Cr-Commit-Position: refs/heads/master@{#422359}

Patch Set 1 #

Patch Set 2 : fix merge conflict #

Patch Set 3 : fix merge conflict again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -60 lines) Patch
M content/browser/browser_main_loop.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/browser_process_sub_thread.cc View 1 2 chunks +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +0 lines, -26 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
falken
Created Revert of Check that all shared workers are terminated. (patchset #2 id:170001 of https://c…
4 years, 2 months ago (2016-10-03 01:00:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385053002/1
4 years, 2 months ago (2016-10-03 01:00:38 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/78882) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 2 months ago (2016-10-03 01:02:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385053002/170001
4 years, 2 months ago (2016-10-03 01:29:26 UTC) #8
horo
lgtm
4 years, 2 months ago (2016-10-03 01:52:02 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:170001)
4 years, 2 months ago (2016-10-03 02:12:12 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 02:14:36 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/eb3de882fc78dd4604a2dfb6b2a106da127c4ae1
Cr-Commit-Position: refs/heads/master@{#422359}

Powered by Google App Engine
This is Rietveld 408576698