content/browser/shared_worker/shared_worker_service_impl.h - Issue 2385053002: Revert of Check that all shared workers are terminated. (patchset #2 id:170001 of https://c…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/shared_worker/shared_worker_service_impl.h

Issue 2385053002: Revert of Check that all shared workers are terminated. (patchset #2 id:170001 of https://c… (Closed)

Patch Set: fix merge conflict again Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/shared_worker/shared_worker_service_impl.h

diff --git a/content/browser/shared_worker/shared_worker_service_impl.h b/content/browser/shared_worker/shared_worker_service_impl.h

index a697a9b8a79773c7fa0f7ca4e24cb1b81bc98a28..d21807efe1a6bbd7b2d6ee175f02423585507789 100644

--- a/content/browser/shared_worker/shared_worker_service_impl.h

+++ b/content/browser/shared_worker/shared_worker_service_impl.h

@@ -98,12 +98,6 @@ class CONTENT_EXPORT SharedWorkerServiceImpl

void NotifyWorkerDestroyed(int worker_process_id, int worker_route_id);

- // TODO(alokp): Remove after collecting crash data.

- // Temporary checks to verify that all shared workers are terminated.

- // It is suspected that shared workers prevent render process hosts

- // from shutting down: crbug.com/608049

- void CheckAllWorkersTerminated();

private:

class SharedWorkerPendingInstance;

class SharedWorkerReserver;