Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2384983002: Subzero: Remove --skip-unimplemented from ARM lit tests. (Closed)

Created:
4 years, 2 months ago by Jim Stichnoth
Modified:
4 years, 2 months ago
Reviewers:
John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Remove --skip-unimplemented from ARM lit tests. ARM support is complete, so clean up some of the lit tests: 1. Remove --skip-unimplemented 2. Use --filetype=obj instead of =asm, and remove --assemble 3. Remove --need=allow_dump requirement 4. Remove related TODOs. 5. Fix some CHECK lines because objdump output is slightly different from filetype=asm output. BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=033dda7ec0c31f6de17890ccb05859766269c548

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -198 lines) Patch
M tests_lit/llvm2ice_tests/64bit.pnacl.ll View 1 chunk +8 lines, -11 lines 0 comments Download
M tests_lit/llvm2ice_tests/alloc.ll View 1 chunk +8 lines, -11 lines 0 comments Download
M tests_lit/llvm2ice_tests/arith.ll View 1 chunk +12 lines, -15 lines 0 comments Download
M tests_lit/llvm2ice_tests/bitcast.ll View 2 chunks +8 lines, -8 lines 0 comments Download
M tests_lit/llvm2ice_tests/bool-folding.ll View 8 chunks +16 lines, -16 lines 0 comments Download
M tests_lit/llvm2ice_tests/branch-opt.ll View 1 chunk +6 lines, -9 lines 0 comments Download
M tests_lit/llvm2ice_tests/callindirect.pnacl.ll View 1 chunk +8 lines, -11 lines 0 comments Download
M tests_lit/llvm2ice_tests/convert.ll View 1 chunk +8 lines, -11 lines 0 comments Download
M tests_lit/llvm2ice_tests/fp.arith.ll View 1 chunk +8 lines, -8 lines 0 comments Download
M tests_lit/llvm2ice_tests/fp.arm.call.ll View 1 chunk +8 lines, -8 lines 0 comments Download
M tests_lit/llvm2ice_tests/fp.cmp.ll View 2 chunks +5 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/fp.convert.ll View 2 chunks +8 lines, -8 lines 0 comments Download
M tests_lit/llvm2ice_tests/function_aligned.ll View 1 chunk +4 lines, -7 lines 0 comments Download
M tests_lit/llvm2ice_tests/globalinit.pnacl.ll View 2 chunks +3 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/int-arg.ll View 1 chunk +4 lines, -7 lines 0 comments Download
M tests_lit/llvm2ice_tests/large_stack_offs.ll View 1 chunk +4 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-atomic-intrinsics.ll View 1 chunk +3 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-mem-intrinsics.ll View 1 chunk +4 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll View 2 chunks +5 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/reorder-global-variables.ll View 1 chunk +6 lines, -7 lines 0 comments Download
M tests_lit/llvm2ice_tests/return_immediates.ll View 1 chunk +4 lines, -7 lines 0 comments Download
M tests_lit/llvm2ice_tests/select-opt.ll View 1 chunk +6 lines, -6 lines 0 comments Download
M tests_lit/llvm2ice_tests/shift.ll View 1 chunk +8 lines, -11 lines 0 comments Download
M tests_lit/llvm2ice_tests/switch-opt.ll View 1 chunk +4 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/unreachable.ll View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
Jim Stichnoth
4 years, 2 months ago (2016-10-01 18:27:30 UTC) #5
John
lgtm
4 years, 2 months ago (2016-10-03 13:55:50 UTC) #6
Jim Stichnoth
4 years, 2 months ago (2016-10-03 14:56:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
033dda7ec0c31f6de17890ccb05859766269c548 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698