[DevTools] Fixed breakpoints in hotreloaded scripts

[DevTools] Fixed breakpoints in hotreloaded scripts

We need to use last arrived script for ResourceScriptFile.
Otherwise _isDiverged check will always return true in case of:
eval("source1 //# sourceURL=foo.js")
eval("source2 //# sourceURL=foo.js")

BUG=617450, 623150
R=lushnikov@chromium.org

Committed: https://crrev.com/c0d25adc44ebd36c2dc2565942a1884479c40004
Cr-Commit-Position: refs/heads/master@{#422622}

[kozy, 2016-10-01 05:11:42]

Andrey, please take a look! If it is fine, I'll add a test on Monday.

[lushnikov, 2016-10-01 19:24:18]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-01 19:24:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 20:28:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 20:28:10]

Dry run: Exceeded global retry quota

[dgozman, 2016-10-03 03:02:04]

On 2016/10/01 05:11:42, kozyatinskiy wrote:
> Andrey, please take a look! If it is fine, I'll add a test on Monday.

We definitely need a test :-)

[kozy, 2016-10-03 19:01:51]

test added, please take a look!

[kozy, 2016-10-03 19:02:36]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[kozy, 2016-10-03 19:02:46]

The CQ bit was unchecked by kozyatinskiy@chromium.org

[kozy, 2016-10-03 19:11:21]

Patchset #2 (id:20001) has been deleted

[kozy, 2016-10-03 19:12:17]

Patchset #2 (id:30004) has been deleted

[lushnikov, 2016-10-03 20:07:54]

lgtm (don't forget to merge!)

https://codereview.chromium.org/2384953002/diff/50001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/dont-diverge-script-evaluated-twice.html
(right):

https://codereview.chromium.org/2384953002/diff/50001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/dont-diverge-script-evaluated-twice.html:32:
InspectorTest.completeDebuggerTest();
return;

https://codereview.chromium.org/2384953002/diff/50001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/dont-diverge-script-evaluated-twice.html:39:
scriptFile.addEventListener(WebInspector.ResourceScriptFile.Events.DidDivergeFromVM,
dumpDivergeFromVM, this);
scriptFile is a new one; this won't fire

[kozy, 2016-10-03 20:45:18]

thanks! all done.

https://codereview.chromium.org/2384953002/diff/50001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/dont-diverge-script-evaluated-twice.html
(right):

https://codereview.chromium.org/2384953002/diff/50001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/dont-diverge-script-evaluated-twice.html:32:
InspectorTest.completeDebuggerTest();
On 2016/10/03 20:07:53, lushnikov wrote:
> return;

Done.

https://codereview.chromium.org/2384953002/diff/50001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/dont-diverge-script-evaluated-twice.html:39:
scriptFile.addEventListener(WebInspector.ResourceScriptFile.Events.DidDivergeFromVM,
dumpDivergeFromVM, this);
On 2016/10/03 20:07:53, lushnikov wrote:
> scriptFile is a new one; this won't fire

Done.

[kozy, 2016-10-03 20:45:24]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-10-03 20:45:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2384953002/#ps70001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-10-03 20:46:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 22:01:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 22:01:15]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[kozy, 2016-10-03 23:01:23]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-10-03 23:02:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 00:23:20]

Committed patchset #3 (id:70001)

[commit-bot: I haz the power, 2016-10-04 00:26:47]

Description was changed from

==========
[DevTools] Fixed breakpoints in hotreloaded scripts

We need to use last arrived script for ResourceScriptFile.
Otherwise _isDiverged check will always return true in case of:
eval("source1 //# sourceURL=foo.js")
eval("source2 //# sourceURL=foo.js")

BUG=617450,623150
R=lushnikov@chromium.org
==========

to

==========
[DevTools] Fixed breakpoints in hotreloaded scripts

We need to use last arrived script for ResourceScriptFile.
Otherwise _isDiverged check will always return true in case of:
eval("source1 //# sourceURL=foo.js")
eval("source2 //# sourceURL=foo.js")

BUG=617450,623150
R=lushnikov@chromium.org

Committed: https://crrev.com/c0d25adc44ebd36c2dc2565942a1884479c40004
Cr-Commit-Position: refs/heads/master@{#422622}
==========

[commit-bot: I haz the power, 2016-10-04 00:26:48]

Patchset 3 (id:??) landed as
https://crrev.com/c0d25adc44ebd36c2dc2565942a1884479c40004
Cr-Commit-Position: refs/heads/master@{#422622}