PVer4: Test checksum on startup outside the hotpath of DB load

components/safe_browsing_db/v4_database.cc

Index: components/safe_browsing_db/v4_database.cc
diff --git a/components/safe_browsing_db/v4_database.cc b/components/safe_browsing_db/v4_database.cc
index efcbe7b1aaa5eea6e23df6f255b8055e8add198c..8131caebbabbc5f7ecf13c2208df30064ac19986 100644
--- a/components/safe_browsing_db/v4_database.cc
+++ b/components/safe_browsing_db/v4_database.cc
@@ -154,13 +154,10 @@ void V4Database::UpdatedStoreReady(ListIdentifier identifier,
 
 bool V4Database::ResetDatabase() {
   DCHECK(db_task_runner_->RunsTasksOnCurrentThread());
-  bool reset_success = true;
   for (const auto& store_map_iter : *store_map_) {
-    if (!store_map_iter.second->Reset()) {
-      reset_success = false;
-    }
+    store_map_iter.second->Reset();
   }
-  return reset_success;
+  return true;

[Scott Hess - ex-Googler, 2016/10/05 04:42:13]

Does this leave any implementations which can return false?  If not, change the
function's signature to void.

[vakh (use Gerrit instead), 2016/10/05 23:49:32]

Done.

 }
 
 std::unique_ptr<StoreStateMap> V4Database::GetStoreStateMap() {