PVer4: Test checksum on startup outside the hotpath of DB load

components/safe_browsing_db/v4_database.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 
 #include "base/callback.h"
 #include "base/debug/leak_annotations.h"
 #include "base/files/file_util.h"
 #include "base/memory/ptr_util.h"
@@ skipping 136 matching lines @@
 
   pending_store_updates_--;
   if (!pending_store_updates_) {
     db_updated_callback_.Run();
     db_updated_callback_.Reset();
   }
 }
 
 bool V4Database::ResetDatabase() {
   DCHECK(db_task_runner_->RunsTasksOnCurrentThread());
-  bool reset_success = true;
   for (const auto& store_map_iter : *store_map_) {
-    if (!store_map_iter.second->Reset()) {
-      reset_success = false;
-    }
+    store_map_iter.second->Reset();
   }
-  return reset_success;
+  return true;

[Scott Hess - ex-Googler, 2016/10/05 04:42:13]

Does this leave any implementations which can return false?  If not, change the
function's signature to void.

[vakh (use Gerrit instead), 2016/10/05 23:49:32]

Done.

 }
 
 std::unique_ptr<StoreStateMap> V4Database::GetStoreStateMap() {
   std::unique_ptr<StoreStateMap> store_state_map =
       base::MakeUnique<StoreStateMap>();
   for (const auto& store_map_iter : *store_map_) {
     (*store_state_map)[store_map_iter.first] = store_map_iter.second->state();
   }
   return store_state_map;
 }
@@ skipping 23 matching lines @@
       filename_(filename),
       list_id_(list_id),
       sb_threat_type_(sb_threat_type) {
   DCHECK(!fetch_updates_ || !filename_.empty());
   DCHECK_NE(SB_THREAT_TYPE_SAFE, sb_threat_type_);
 }
 
 ListInfo::~ListInfo() {}
 
 }  // namespace safe_browsing