Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1762)

Unified Diff: core/fpdfapi/fpdf_page/cpdf_image.cpp

Issue 2384883003: Remove CPDF_Object::Release() in favor of direct delete (Closed)
Patch Set: Remove ScopedDict typedefs Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: core/fpdfapi/fpdf_page/cpdf_image.cpp
diff --git a/core/fpdfapi/fpdf_page/cpdf_image.cpp b/core/fpdfapi/fpdf_page/cpdf_image.cpp
index 21cec2e442207e8cb188d1ac18b4f39c94d0846b..4fe23fa0bb9ab8217e139729ab68ca3d717d7521 100644
--- a/core/fpdfapi/fpdf_page/cpdf_image.cpp
+++ b/core/fpdfapi/fpdf_page/cpdf_image.cpp
@@ -55,10 +55,8 @@ CPDF_Image::CPDF_Image(CPDF_Document* pDoc, CPDF_Stream* pStream, bool bInline)
CPDF_Image::~CPDF_Image() {
if (m_bInline) {
- if (m_pStream)
- m_pStream->Release();
- if (m_pInlineDict)
- m_pInlineDict->Release();
+ delete m_pStream;
+ delete m_pInlineDict;
}
}
@@ -289,7 +287,7 @@ void CPDF_Image::SetImage(const CFX_DIBitmap* pBitmap, int32_t iCompress) {
pNewBitmap->ConvertFormat(FXDIB_Rgb);
SetImage(pNewBitmap, iCompress);
if (pDict) {
Lei Zhang 2016/10/03 21:50:47 no if?
Tom Sepez 2016/10/05 21:03:02 Done.
- pDict->Release();
+ delete pDict;
pDict = nullptr;
}
FX_Free(dest_buf);

Powered by Google App Engine
This is Rietveld 408576698