Remove CPDF_Object::Release() in favor of direct delete

core/fpdfapi/fpdf_page/cpdf_image.cpp

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfapi/fpdf_page/cpdf_image.h"
 
 #include <algorithm>
 #include <memory>
@@ skipping 37 matching lines @@
   m_pOC = pDict->GetDictFor("OC");
   m_bIsMask =
       !pDict->KeyExist("ColorSpace") || pDict->GetIntegerFor("ImageMask");
   m_bInterpolate = !!pDict->GetIntegerFor("Interpolate");
   m_Height = pDict->GetIntegerFor("Height");
   m_Width = pDict->GetIntegerFor("Width");
 }
 
 CPDF_Image::~CPDF_Image() {
   if (m_bInline) {
-    if (m_pStream)
-      m_pStream->Release();
-    if (m_pInlineDict)
-      m_pInlineDict->Release();
+    delete m_pStream;
+    delete m_pInlineDict;
   }
 }
 
 CPDF_Image* CPDF_Image::Clone() {
   if (m_pStream->GetObjNum())
     return m_pDocument->GetPageData()->GetImage(m_pStream);
 
   CPDF_Image* pImage =
       new CPDF_Image(m_pDocument, ToStream(m_pStream->Clone()), m_bInline);
   if (m_bInline)
@@ skipping 209 matching lines @@
   }
   if (opType == 0) {
     if (iCompress & PDF_IMAGE_LOSSLESS_COMPRESS) {
     } else {
       if (pBitmap->GetBPP() == 1) {
       } else if (pBitmap->GetBPP() >= 8 && pBitmap->GetPalette()) {
         CFX_DIBitmap* pNewBitmap = new CFX_DIBitmap();
         pNewBitmap->Copy(pBitmap);
         pNewBitmap->ConvertFormat(FXDIB_Rgb);
         SetImage(pNewBitmap, iCompress);
         if (pDict) {

[Lei Zhang, 2016/10/03 21:50:47]

no if?

[Tom Sepez, 2016/10/05 21:03:02]

Done.

-          pDict->Release();
+          delete pDict;
           pDict = nullptr;
         }
         FX_Free(dest_buf);
         dest_buf = nullptr;
         dest_size = 0;
         delete pNewBitmap;
         return;
       }
     }
   } else if (opType == 1) {
@@ skipping 99 matching lines @@
   }
   if (!ret) {
     delete m_pDIBSource;
     m_pDIBSource = nullptr;
     return FALSE;
   }
   m_pMask = pSource->DetachMask();
   m_MatteColor = pSource->GetMatteColor();
   return FALSE;
 }