Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2032)

Unified Diff: core/fpdfapi/parser/cpdf_string.h

Issue 2384883003: Remove CPDF_Object::Release() in favor of direct delete (Closed)
Patch Set: nits Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: core/fpdfapi/parser/cpdf_string.h
diff --git a/core/fpdfapi/parser/cpdf_string.h b/core/fpdfapi/parser/cpdf_string.h
index d99e00c40386ba97fcc47b08933ebcd351a8f581..03284d9c5b19f43bc6f15f43ca994a5297ea1ab4 100644
--- a/core/fpdfapi/parser/cpdf_string.h
+++ b/core/fpdfapi/parser/cpdf_string.h
@@ -16,6 +16,7 @@ class CPDF_String : public CPDF_Object {
CPDF_String();
CPDF_String(const CFX_ByteString& str, FX_BOOL bHex);
explicit CPDF_String(const CFX_WideString& str);
+ ~CPDF_String() override;
// CPDF_Object.
Type GetType() const override;
@@ -30,8 +31,6 @@ class CPDF_String : public CPDF_Object {
FX_BOOL IsHex() const { return m_bHex; }
protected:
- ~CPDF_String() override;
-
CFX_ByteString m_String;
FX_BOOL m_bHex;
};

Powered by Google App Engine
This is Rietveld 408576698