core/fpdfapi/parser/cpdf_stream.cpp - Issue 2384883003: Remove CPDF_Object::Release() in favor of direct delete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/parser/cpdf_stream.cpp

Issue 2384883003: Remove CPDF_Object::Release() in favor of direct delete (Closed)

Patch Set: nits Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/parser/cpdf_stream.cpp

diff --git a/core/fpdfapi/parser/cpdf_stream.cpp b/core/fpdfapi/parser/cpdf_stream.cpp

index 935c80c5c890d36d37a626a5e41a65a9efa7d7c1..f75e249c99ea26a8b1b9512014bb7a26f0acffd1 100644

--- a/core/fpdfapi/parser/cpdf_stream.cpp

+++ b/core/fpdfapi/parser/cpdf_stream.cpp

@@ -15,7 +15,7 @@

CPDF_Stream::CPDF_Stream() {}

CPDF_Stream::CPDF_Stream(uint8_t* pData, uint32_t size, CPDF_Dictionary* pDict)

- : m_pDict(pDict), m_dwSize(size), m_pDataBuf(pData) {}

+ : m_dwSize(size), m_pDict(pDict), m_pDataBuf(pData) {}

CPDF_Stream::~CPDF_Stream() {

m_ObjNum = kInvalidObjNum;