Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2384813002: Don't wait to close tabs waiting for JavaScript dialogs. (Closed)

Created:
4 years, 2 months ago by Avi (use Gerrit)
Modified:
4 years, 2 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't wait to close tabs waiting for JavaScript dialogs. They're known unresponsive, so nothing is gained. BUG=629964 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/85ee8366930c2b8354c1ecfef99f2ff8fea4aa13 Cr-Commit-Position: refs/heads/master@{#424044}

Patch Set 1 #

Patch Set 2 : fix? #

Patch Set 3 : fix #

Total comments: 2

Patch Set 4 : simpler #

Patch Set 5 : fix #

Patch Set 6 : now a bit on webcontents, no timer fiddling #

Total comments: 2

Patch Set 7 : better #

Total comments: 4

Patch Set 8 : remove code no longer needed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -12 lines) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 4 5 6 7 1 chunk +15 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.cc View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 3 4 5 6 2 chunks +8 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 2 3 4 5 6 2 chunks +5 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 4 5 6 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 50 (37 generated)
Avi (use Gerrit)
4 years, 2 months ago (2016-10-05 18:55:44 UTC) #19
Charlie Reis
I'm wondering if a different approach would work, since I'd like to avoid adding SetHangMonitorKnownUnresponsive ...
4 years, 2 months ago (2016-10-05 22:00:59 UTC) #20
Avi (use Gerrit)
On 2016/10/05 22:00:59, Charlie Reis wrote: > I'm wondering if a different approach would work, ...
4 years, 2 months ago (2016-10-06 18:38:23 UTC) #21
Avi (use Gerrit)
4 years, 2 months ago (2016-10-06 18:41:13 UTC) #23
Charlie Reis
On 2016/10/06 18:38:23, Avi wrote: > On 2016/10/05 22:00:59, Charlie Reis wrote: > > I'm ...
4 years, 2 months ago (2016-10-06 22:34:01 UTC) #31
Avi (use Gerrit)
4 years, 2 months ago (2016-10-07 22:25:09 UTC) #36
Charlie Reis
Looking better! One question below, though. https://codereview.chromium.org/2384813002/diff/100001/content/browser/frame_host/render_frame_host_impl.cc File content/browser/frame_host/render_frame_host_impl.cc (right): https://codereview.chromium.org/2384813002/diff/100001/content/browser/frame_host/render_frame_host_impl.cc#newcode2400 content/browser/frame_host/render_frame_host_impl.cc:2400: RenderWidgetHostDelegate::RENDERER_UNRESPONSIVE_DIALOG_SHOWING); Could we ...
4 years, 2 months ago (2016-10-07 22:44:23 UTC) #37
Avi (use Gerrit)
Please take a look. Much better. https://codereview.chromium.org/2384813002/diff/100001/content/browser/frame_host/render_frame_host_impl.cc File content/browser/frame_host/render_frame_host_impl.cc (right): https://codereview.chromium.org/2384813002/diff/100001/content/browser/frame_host/render_frame_host_impl.cc#newcode2400 content/browser/frame_host/render_frame_host_impl.cc:2400: RenderWidgetHostDelegate::RENDERER_UNRESPONSIVE_DIALOG_SHOWING); On 2016/10/07 ...
4 years, 2 months ago (2016-10-08 00:13:19 UTC) #40
Charlie Reis
Great! LGTM, though I don't think we need the new enum value anymore. https://codereview.chromium.org/2384813002/diff/120001/content/browser/renderer_host/render_widget_host_delegate.h File ...
4 years, 2 months ago (2016-10-08 00:20:27 UTC) #41
Avi (use Gerrit)
https://codereview.chromium.org/2384813002/diff/120001/content/browser/renderer_host/render_widget_host_delegate.h File content/browser/renderer_host/render_widget_host_delegate.h (right): https://codereview.chromium.org/2384813002/diff/120001/content/browser/renderer_host/render_widget_host_delegate.h#newcode154 content/browser/renderer_host/render_widget_host_delegate.h:154: RENDERER_UNRESPONSIVE_DIALOG_SHOWING = 7, On 2016/10/08 00:20:27, Charlie Reis (Away ...
4 years, 2 months ago (2016-10-08 00:44:24 UTC) #46
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384813002/140001
4 years, 2 months ago (2016-10-08 00:44:41 UTC) #47
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 2 months ago (2016-10-08 02:09:32 UTC) #48
commit-bot: I haz the power
4 years, 2 months ago (2016-10-08 02:11:07 UTC) #50
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/85ee8366930c2b8354c1ecfef99f2ff8fea4aa13
Cr-Commit-Position: refs/heads/master@{#424044}

Powered by Google App Engine
This is Rietveld 408576698