Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: content/browser/web_contents/web_contents_impl.h

Issue 2384813002: Don't wait to close tabs waiting for JavaScript dialogs. (Closed)
Patch Set: remove code no longer needed Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <functional> 10 #include <functional>
(...skipping 547 matching lines...) Expand 10 before | Expand all | Expand 10 after
558 const gfx::Rect& initial_rect) override; 558 const gfx::Rect& initial_rect) override;
559 void ShowCreatedFullscreenWidget(int process_id, int route_id) override; 559 void ShowCreatedFullscreenWidget(int process_id, int route_id) override;
560 void RequestMediaAccessPermission( 560 void RequestMediaAccessPermission(
561 const MediaStreamRequest& request, 561 const MediaStreamRequest& request,
562 const MediaResponseCallback& callback) override; 562 const MediaResponseCallback& callback) override;
563 bool CheckMediaAccessPermission(const GURL& security_origin, 563 bool CheckMediaAccessPermission(const GURL& security_origin,
564 MediaStreamType type) override; 564 MediaStreamType type) override;
565 SessionStorageNamespace* GetSessionStorageNamespace( 565 SessionStorageNamespace* GetSessionStorageNamespace(
566 SiteInstance* instance) override; 566 SiteInstance* instance) override;
567 SessionStorageNamespaceMap GetSessionStorageNamespaceMap() override; 567 SessionStorageNamespaceMap GetSessionStorageNamespaceMap() override;
568 double GetPendingPageZoomLevel() override;
568 FrameTree* GetFrameTree() override; 569 FrameTree* GetFrameTree() override;
569 void SetIsVirtualKeyboardRequested(bool requested) override; 570 void SetIsVirtualKeyboardRequested(bool requested) override;
570 bool IsVirtualKeyboardRequested() override; 571 bool IsVirtualKeyboardRequested() override;
571 bool IsOverridingUserAgent() override; 572 bool IsOverridingUserAgent() override;
572 double GetPendingPageZoomLevel() override; 573 bool IsJavaScriptDialogShowing() const override;
573 574
574 // NavigatorDelegate --------------------------------------------------------- 575 // NavigatorDelegate ---------------------------------------------------------
575 576
576 void DidStartNavigation(NavigationHandle* navigation_handle) override; 577 void DidStartNavigation(NavigationHandle* navigation_handle) override;
577 void DidRedirectNavigation(NavigationHandle* navigation_handle) override; 578 void DidRedirectNavigation(NavigationHandle* navigation_handle) override;
578 void ReadyToCommitNavigation(NavigationHandle* navigation_handle) override; 579 void ReadyToCommitNavigation(NavigationHandle* navigation_handle) override;
579 void DidFinishNavigation(NavigationHandle* navigation_handle) override; 580 void DidFinishNavigation(NavigationHandle* navigation_handle) override;
580 void DidStartProvisionalLoad(RenderFrameHostImpl* render_frame_host, 581 void DidStartProvisionalLoad(RenderFrameHostImpl* render_frame_host,
581 const GURL& validated_url, 582 const GURL& validated_url,
582 bool is_error_page, 583 bool is_error_page,
(...skipping 703 matching lines...) Expand 10 before | Expand all | Expand 10 after
1286 // Indicates whether we should notify about disconnection of this 1287 // Indicates whether we should notify about disconnection of this
1287 // WebContentsImpl. This is used to ensure disconnection notifications only 1288 // WebContentsImpl. This is used to ensure disconnection notifications only
1288 // happen if a connection notification has happened and that they happen only 1289 // happen if a connection notification has happened and that they happen only
1289 // once. 1290 // once.
1290 bool notify_disconnection_; 1291 bool notify_disconnection_;
1291 1292
1292 // Pointer to the JavaScript dialog manager, lazily assigned. Used because the 1293 // Pointer to the JavaScript dialog manager, lazily assigned. Used because the
1293 // delegate of this WebContentsImpl is nulled before its destructor is called. 1294 // delegate of this WebContentsImpl is nulled before its destructor is called.
1294 JavaScriptDialogManager* dialog_manager_; 1295 JavaScriptDialogManager* dialog_manager_;
1295 1296
1297 // Set to true when there is an active JavaScript dialog showing.
1298 bool is_showing_javascript_dialog_ = false;
1299
1296 // Set to true when there is an active "before unload" dialog. When true, 1300 // Set to true when there is an active "before unload" dialog. When true,
1297 // we've forced the throbber to start in Navigate, and we need to remember to 1301 // we've forced the throbber to start in Navigate, and we need to remember to
1298 // turn it off in OnJavaScriptMessageBoxClosed if the navigation is canceled. 1302 // turn it off in OnJavaScriptMessageBoxClosed if the navigation is canceled.
1299 bool is_showing_before_unload_dialog_; 1303 bool is_showing_before_unload_dialog_;
1300 1304
1301 // Settings that get passed to the renderer process. 1305 // Settings that get passed to the renderer process.
1302 RendererPreferences renderer_preferences_; 1306 RendererPreferences renderer_preferences_;
1303 1307
1304 // The time that this WebContents was last made active. The initial value is 1308 // The time that this WebContents was last made active. The initial value is
1305 // the WebContents creation time. 1309 // the WebContents creation time.
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
1484 // Adds/removes a callback called on creation of each new WebContents. 1488 // Adds/removes a callback called on creation of each new WebContents.
1485 static void AddCreatedCallbackForTesting(const CreatedCallback& callback); 1489 static void AddCreatedCallbackForTesting(const CreatedCallback& callback);
1486 static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback); 1490 static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback);
1487 1491
1488 DISALLOW_COPY_AND_ASSIGN(FriendZone); 1492 DISALLOW_COPY_AND_ASSIGN(FriendZone);
1489 }; 1493 };
1490 1494
1491 } // namespace content 1495 } // namespace content
1492 1496
1493 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 1497 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698