Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Issue 2384693004: Show "Detailed build info" subpage in About (Closed)

Created:
4 years, 2 months ago by michaelpg
Modified:
4 years, 2 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show "Detailed build info" subpage in About BUG=642021 R=tommycli@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/51051c6a3faf94f8287f58eb6d0a3b932044bea2 Cr-Commit-Position: refs/heads/master@{#422245}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/resources/settings/route.js View 1 chunk +4 lines, -3 lines 2 comments Download

Messages

Total messages: 10 (3 generated)
michaelpg
4 years, 2 months ago (2016-09-30 20:50:46 UTC) #2
tommycli
https://codereview.chromium.org/2384693004/diff/1/chrome/browser/resources/settings/route.js File chrome/browser/resources/settings/route.js (left): https://codereview.chromium.org/2384693004/diff/1/chrome/browser/resources/settings/route.js#oldcode202 chrome/browser/resources/settings/route.js:202: r.INPUT_METHODS = r.LANGUAGES.createChild('/inputMethods'); Should INPUT_METHODS actually be gone?
4 years, 2 months ago (2016-09-30 21:04:30 UTC) #3
michaelpg
https://codereview.chromium.org/2384693004/diff/1/chrome/browser/resources/settings/route.js File chrome/browser/resources/settings/route.js (left): https://codereview.chromium.org/2384693004/diff/1/chrome/browser/resources/settings/route.js#oldcode202 chrome/browser/resources/settings/route.js:202: r.INPUT_METHODS = r.LANGUAGES.createChild('/inputMethods'); On 2016/09/30 21:04:30, tommycli wrote: > ...
4 years, 2 months ago (2016-09-30 21:07:15 UTC) #4
tommycli
lgtm thx
4 years, 2 months ago (2016-09-30 21:07:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384693004/1
4 years, 2 months ago (2016-09-30 21:25:31 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 22:31:00 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 22:34:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51051c6a3faf94f8287f58eb6d0a3b932044bea2
Cr-Commit-Position: refs/heads/master@{#422245}

Powered by Google App Engine
This is Rietveld 408576698