Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7451)

Unified Diff: chrome/browser/resources/settings/route.js

Issue 2384693004: Show "Detailed build info" subpage in About (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/route.js
diff --git a/chrome/browser/resources/settings/route.js b/chrome/browser/resources/settings/route.js
index e987f33ed83daf70c886db7251935111323cfcbf..cc184bb727d875b09612bdb759fbf681dbe4d7d0 100644
--- a/chrome/browser/resources/settings/route.js
+++ b/chrome/browser/resources/settings/route.js
@@ -199,9 +199,10 @@ cr.define('settings', function() {
r.RESET = r.ADVANCED.createSection('/reset', 'reset');
<if expr="chromeos">
- r.INPUT_METHODS = r.LANGUAGES.createChild('/inputMethods');
tommycli 2016/09/30 21:04:30 Should INPUT_METHODS actually be gone?
michaelpg 2016/09/30 21:07:15 it's a dupe (from above)
- r.DETAILED_BUILD_INFO = r.ABOUT.createChild('/help/details');
- r.DETAILED_BUILD_INFO.section = 'about';
+ // "About" is the only section in About, but we still need to create the route
+ // in order to show the subpage on Chrome OS.
+ r.ABOUT_ABOUT = r.ABOUT.createSection('/help/about', 'about');
+ r.DETAILED_BUILD_INFO = r.ABOUT_ABOUT.createChild('/help/details');
</if>
var routeObservers_ = new Set();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698