Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2384633004: misc files: Change ScopedTempDir::path() to GetPath() (Closed)

Created:
4 years, 2 months ago by vabr (Chromium)
Modified:
4 years, 2 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, Lei Zhang, tommycli
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

misc files: Change ScopedTempDir::path() to GetPath() path() is being deprecated, GetPath() has better checking against wrong use. For more context, see https://codereview.chromium.org/2275553005/. BUG=640599 TBR=reillyg@chromium.org Committed: https://crrev.com/de15d7ce181a2066164aee958071cd19479cadcc Cr-Commit-Position: refs/heads/master@{#422090}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
vabr (Chromium)
Hello Reilly, I put you in TBR for this CL. The changes there are trivial, ...
4 years, 2 months ago (2016-09-30 12:11:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384633004/1
4 years, 2 months ago (2016-09-30 12:11:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 12:49:05 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/de15d7ce181a2066164aee958071cd19479cadcc Cr-Commit-Position: refs/heads/master@{#422090}
4 years, 2 months ago (2016-09-30 12:50:58 UTC) #9
Reilly Grant (use Gerrit)
4 years, 2 months ago (2016-09-30 14:51:27 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698