Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Unified Diff: third_party/WebKit/Source/modules/vr/VRPose.h

Issue 2384593002: Encode frame number in pixel data for pose sync (Closed)
Patch Set: bajones #4: use contextGL(), auto-restore state, add poseNum to VRPosePtr Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/vr/VRPose.h
diff --git a/third_party/WebKit/Source/modules/vr/VRPose.h b/third_party/WebKit/Source/modules/vr/VRPose.h
index fc7d85db07707ff83d58afabf2c599057e7ce784..84e2319a59eb8d4e4a161c610124a39a12c29ae2 100644
--- a/third_party/WebKit/Source/modules/vr/VRPose.h
+++ b/third_party/WebKit/Source/modules/vr/VRPose.h
@@ -26,6 +26,10 @@ class VRPose final : public GarbageCollected<VRPose>, public ScriptWrappable {
DOMFloat32Array* angularAcceleration() const { return m_angularAcceleration; }
DOMFloat32Array* linearAcceleration() const { return m_linearAcceleration; }
+ // TODO(klausw): expose timestamp and poseNum to JS? We have those in the
bajones 2016/10/04 06:33:57 timestamp is exposed in the VRFrameData object. I
klausw 2016/10/04 06:47:04 OK, I'll remove the comment. When you mentioned Oc
klausw 2016/10/04 17:52:47 Removed the comment.
+ // underlying VRPosePtr, and they could be useful to scripts. If yes,
+ // they would need to be added to VRPose in the WebVR spec.
+
void setPose(const device::blink::VRPosePtr&);
DECLARE_VIRTUAL_TRACE();

Powered by Google App Engine
This is Rietveld 408576698