Deflake storage/websql/transaction-removed-context-crash.html

Deflake storage/websql/transaction-removed-context-crash.html

Test relied on an arbitrary timeout to determine if the conditions
leading to a (now fixed) crash had passed. That introduced flakiness
where the timeout could fire before the test logic was complete on
slower machines.

Replace the arbitrary timeout with a poll that waits for a certain
condition instead, and re-enable the test.

BUG=651502
R=alexmos@chromium.org

Committed: https://crrev.com/b9bd580e1f1c84ed970446ba780f96c48adcf788
Cr-Commit-Position: refs/heads/master@{#421973}

[jsbell, 2016-09-29 20:01:59]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 20:02:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jsbell, 2016-09-29 20:04:24]

alexmos@ - can you take a look? The test fix is just to poll on an iframe being
removed - no knowledge of websql required. :)

On my system this still consistently crashed w/ the original fix in
https://codereview.chromium.org/2375733003 backed out.

[alexmos, 2016-09-29 21:00:57]

LGTM

[commit-bot: I haz the power, 2016-09-29 21:50:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 21:50:13]

Dry run: This issue passed the CQ dry run.

[jsbell, 2016-09-29 23:04:26]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2016-09-29 23:04:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 23:11:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-29 23:16:29]

Description was changed from

==========
Deflake storage/websql/transaction-removed-context-crash.html

Test relied on an arbitrary timeout to determine if the conditions
leading to a (now fixed) crash had passed. That introduced flakiness
where the timeout could fire before the test logic was complete on
slower machines.

Replace the arbitrary timeout with a poll that waits for a certain
condition instead, and re-enable the test.

BUG=651502
R=alexmos@chromium.org
==========

to

==========
Deflake storage/websql/transaction-removed-context-crash.html

Test relied on an arbitrary timeout to determine if the conditions
leading to a (now fixed) crash had passed. That introduced flakiness
where the timeout could fire before the test logic was complete on
slower machines.

Replace the arbitrary timeout with a poll that waits for a certain
condition instead, and re-enable the test.

BUG=651502
R=alexmos@chromium.org

Committed: https://crrev.com/b9bd580e1f1c84ed970446ba780f96c48adcf788
Cr-Commit-Position: refs/heads/master@{#421973}
==========

[commit-bot: I haz the power, 2016-09-29 23:16:30]

Patchset 1 (id:??) landed as
https://crrev.com/b9bd580e1f1c84ed970446ba780f96c48adcf788
Cr-Commit-Position: refs/heads/master@{#421973}