Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 2375733003: Add missing null check in Database::getSecurityOrigin() (Closed)

Created:
4 years, 2 months ago by jsbell
Modified:
4 years, 2 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing null check in Database::getSecurityOrigin() Following r419951 getExecutionContext() may return null, so return value must be checked. BUG=650173 R=haraken@chromium.org Committed: https://crrev.com/0fe809e04a61ce645439aad1b9cf3012271ab6a4 Cr-Commit-Position: refs/heads/master@{#421534}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/storage/websql/transaction-removed-context-crash.html View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/storage/websql/transaction-removed-context-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/Database.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
jsbell
haraken@ - please take a look?
4 years, 2 months ago (2016-09-27 23:48:12 UTC) #2
haraken
Thanks for fixing this! LGTM
4 years, 2 months ago (2016-09-28 00:12:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2375733003/1
4 years, 2 months ago (2016-09-28 16:06:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 16:11:37 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 16:17:56 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fe809e04a61ce645439aad1b9cf3012271ab6a4
Cr-Commit-Position: refs/heads/master@{#421534}

Powered by Google App Engine
This is Rietveld 408576698