Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2384483004: Handling new frames and frame navigations with find-in-page during a find session. (Closed)

Created:
4 years, 2 months ago by paulmeyer
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, jam, dglazkov+blink, darin-cc_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handling new frames and frame navigations with find-in-page during a find session. This patch implements new find-in-page functionality that allows for frames that are either newly added or navigated during a find session to be automatically searched so that matches in their new content are automatically highlighted and included in the results shown in the find bar. Also, there is a fix included in this patch to prevent the find-in-page bar from closing when a subframe navigates (the find session should only end if the main frame navigates). Design doc: https://docs.google.com/document/d/1r4F19FIKg4zPJCaSyJ9-T0sgFbxlCGKL3FjqQEAKegg/view This is a reland of: https://codereview.chromium.org/2236403004/ BUG=2220, 621660 TBR=dcheng@chromium.org,pkasting@chromium.org Committed: https://crrev.com/3ac612d592cd42355a432c8d307051d299d79768 Cr-Commit-Position: refs/heads/master@{#422176}

Patch Set 1 : (original) #

Patch Set 2 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -23 lines) Patch
M chrome/browser/ui/find_bar/find_bar_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/find_request_manager.h View 2 chunks +6 lines, -2 lines 0 comments Download
M content/browser/find_request_manager.cc View 6 chunks +27 lines, -10 lines 0 comments Download
M content/browser/find_request_manager_browsertest.cc View 3 chunks +118 lines, -2 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/TextFinder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/TextFinder.cpp View 1 5 chunks +11 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebFindOptions.h View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 15 (12 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384483004/20001
4 years, 2 months ago (2016-09-30 19:14:40 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-30 19:21:26 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 19:24:20 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3ac612d592cd42355a432c8d307051d299d79768
Cr-Commit-Position: refs/heads/master@{#422176}

Powered by Google App Engine
This is Rietveld 408576698