Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: content/browser/find_request_manager.h

Issue 2384483004: Handling new frames and frame navigations with find-in-page during a find session. (Closed)
Patch Set: Fix. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/find_bar/find_bar_controller.cc ('k') | content/browser/find_request_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/find_request_manager.h
diff --git a/content/browser/find_request_manager.h b/content/browser/find_request_manager.h
index 7dddcc4e0ad267a31eaf1e0ad4dde74386f69bab..5a6b3988d1083017d35dc8b6bd59e33a4c7a315e 100644
--- a/content/browser/find_request_manager.h
+++ b/content/browser/find_request_manager.h
@@ -103,6 +103,7 @@ class CONTENT_EXPORT FindRequestManager : public WebContentsObserver {
};
// WebContentsObserver implementation.
+ void DidFinishLoad(RenderFrameHost* rfh, const GURL& validated_url) override;
void RenderFrameDeleted(RenderFrameHost* rfh) override;
void RenderFrameHostChanged(RenderFrameHost* old_host,
RenderFrameHost* new_host) override;
@@ -145,8 +146,11 @@ class CONTENT_EXPORT FindRequestManager : public WebContentsObserver {
// Adds a frame to the set of frames that are being searched. The new frame
// will automatically be searched when added, using the same options (stored
- // in |current_request_.options|).
- void AddFrame(RenderFrameHost* rfh);
+ // in |current_request_.options|). |force| should be set to true when a
+ // dynamic content change is suspected, which will treat the frame as a newly
+ // added frame even if it has already been searched. This will force a
+ // re-search of the frame.
+ void AddFrame(RenderFrameHost* rfh, bool force);
// Returns whether |rfh| is in the set of frames being searched in the current
// find session.
« no previous file with comments | « chrome/browser/ui/find_bar/find_bar_controller.cc ('k') | content/browser/find_request_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698