[inspector] introduced exceptionThrown support in test runner

[inspector] introduced exceptionThrown support in test runner

BUG=chromium:635948
R=dgozman@chromium.org

Committed: https://crrev.com/e90a79c6378d766f63c623d0944fb2da8ca19ab7
Cr-Commit-Position: refs/heads/master@{#39998}

[kozy, 2016-10-04 01:03:12]

Dmitry, please take a look!

[dgozman, 2016-10-04 18:26:04]

lgtm

https://codereview.chromium.org/2384373002/diff/1/test/inspector/inspector-im...
File test/inspector/inspector-impl.cc (right):

https://codereview.chromium.org/2384373002/diff/1/test/inspector/inspector-im...
test/inspector/inspector-impl.cc:46: return v8_inspector::String16(buffer.get(),
str->Length());
I remember you wanted String16::createUninitialized.

https://codereview.chromium.org/2384373002/diff/1/test/inspector/inspector-im...
test/inspector/inspector-impl.cc:73: if
(message->GetScriptOrigin().ResourceName()->IsString())
missing {}

[kozy, 2016-10-04 20:34:58]

all done, thanks!

https://codereview.chromium.org/2384373002/diff/1/test/inspector/inspector-im...
File test/inspector/inspector-impl.cc (right):

https://codereview.chromium.org/2384373002/diff/1/test/inspector/inspector-im...
test/inspector/inspector-impl.cc:46: return v8_inspector::String16(buffer.get(),
str->Length());
On 2016/10/04 18:26:04, dgozman wrote:
> I remember you wanted String16::createUninitialized.

I'll add it in followup.

https://codereview.chromium.org/2384373002/diff/1/test/inspector/inspector-im...
test/inspector/inspector-impl.cc:73: if
(message->GetScriptOrigin().ResourceName()->IsString())
On 2016/10/04 18:26:04, dgozman wrote:
> missing {}

Done.

[kozy, 2016-10-04 20:35:04]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-10-04 20:35:04]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2384373002/#ps20001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-10-04 20:35:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 20:35:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 20:35:15]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-v8-committers".
Note that this has nothing to do with OWNERS files.

[kozy, 2016-10-05 00:06:41]

kozyatinskiy@chromium.org changed reviewers:
+ alph@chromium.org

[kozy, 2016-10-05 00:06:41]

Alexey, please take a look!

[kozy, 2016-10-05 14:43:00]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-10-05 14:43:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 15:08:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-05 15:08:25]

Description was changed from

==========
[inspector] introduced exceptionThrown support in test runner

BUG=chromium:635948
R=dgozman@chromium.org
==========

to

==========
[inspector] introduced exceptionThrown support in test runner

BUG=chromium:635948
R=dgozman@chromium.org

Committed: https://crrev.com/e90a79c6378d766f63c623d0944fb2da8ca19ab7
Cr-Commit-Position: refs/heads/master@{#39998}
==========

[commit-bot: I haz the power, 2016-10-05 15:08:27]

Patchset 2 (id:??) landed as
https://crrev.com/e90a79c6378d766f63c623d0944fb2da8ca19ab7
Cr-Commit-Position: refs/heads/master@{#39998}