Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: test/inspector/protocol-test.js

Issue 2384373002: [inspector] introduced exceptionThrown support in test runner (Closed)
Patch Set: addressed comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/inspector/inspector-test.cc ('k') | test/inspector/runtime/console-line-and-column-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/inspector/protocol-test.js
diff --git a/test/inspector/protocol-test.js b/test/inspector/protocol-test.js
index 3589d37e1eb2bc5e8f6675f24a5713f676e0f1f0..f7b3ddebba3dcba1e7151d1307570dc66964d042 100644
--- a/test/inspector/protocol-test.js
+++ b/test/inspector/protocol-test.js
@@ -36,7 +36,7 @@ InspectorTest.logMessage = function(message)
if (message.id)
message.id = "<messageId>";
- const nonStableFields = new Set(["objectId", "scriptId", "exceptionId", "timestamp"]);
+ const nonStableFields = new Set(["objectId", "scriptId", "exceptionId", "timestamp", "executionContextId"]);
var objects = [ message ];
while (objects.length) {
var object = objects.shift();
@@ -104,9 +104,9 @@ InspectorTest.completeTest = quit.bind(null);
InspectorTest.completeTestAfterPendingTimeouts = function()
{
- InspectorTest.sendCommand("Runtime.evaluate", {
+ Protocol.Runtime.evaluate({
expression: "new Promise(resolve => setTimeout(resolve, 0))",
- awaitPromise: true }, InspectorTest.completeTest);
+ awaitPromise: true }).then(InspectorTest.completeTest);
}
InspectorTest.addScript = function(string)
« no previous file with comments | « test/inspector/inspector-test.cc ('k') | test/inspector/runtime/console-line-and-column-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698